lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Le Floc'h (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11014) server/solr-webapp/** missing for the eclipse exclusions in build.xml
Date Wed, 05 Jul 2017 17:38:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Antoine Le Floc'h updated SOLR-11014:
-------------------------------------
    Description: 
in the top folder, in build.xml
[https://github.com/apache/lucene-solr/blob/branch_6_6/build.xml]

in the "eclipse" target (line 442, branch_6_6)

{code:java}
   <pathconvert property="eclipse.fileset.libs" pathsep="|" dirsep="/">
      <fileset dir="${basedir}/lucene" includes="**/lib/*.jar" excludes="**/*servlet-api*.jar,
analysis/uima/**, tools/**, build/**"/>
      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />
      <map from="${basedir}/" to=""/>
    </pathconvert>
{code}

Just like in the netbeans target, the fileset excluded should have "server/solr-webapp/**"
also at the end.Otherwise, if I do "ant-eclipse" after "ant generate-maven-artifacts", i get
eclipse errors like:
"The type FacetDoubleMerger is already defined	FacetModule.java	/solr6_/solr/core/src/java/org/apache/solr/search/facet
line 364"

because

{code:java}
<classpathentry kind="lib" path="solr/server/solr-webapp/webapp/WEB-INF/lib/solr-core-6.6.0-SNAPSHOT.jar"/>
{code}

was included in my ".classpath" during the "ant-eclipse" phase.

So at the end of the line 

{code:java}
<fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />
{code}


we should also add:

{code:java}
<fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**, server/solr-webapp/**" />
{code}

Thank you.

  was:
in the top folder, in build.xml
https://github.com/apache/lucene-solr/blob/branch_6_6/build.xml

in the "eclipse" target (line 442, branch_6_6)

   <pathconvert property="eclipse.fileset.libs" pathsep="|" dirsep="/">
      <fileset dir="${basedir}/lucene" includes="**/lib/*.jar" excludes="**/*servlet-api*.jar,
analysis/uima/**, tools/**, build/**"/>
      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />
      <map from="${basedir}/" to=""/>
    </pathconvert>

Just like in the netbeans target, the fileset excluded should have "server/solr-webapp/**"
also at the end.Otherwise, if I do "ant-eclipse" after "ant generate-maven-artifacts", i get
eclipse errors like:
"The type FacetDoubleMerger is already defined	FacetModule.java	/solr6_/solr/core/src/java/org/apache/solr/search/facet
line 364"

because
"<classpathentry kind="lib" path="solr/server/solr-webapp/webapp/WEB-INF/lib/solr-core-6.6.0-SNAPSHOT.jar"/>"
was included in my ".classpath" during the "ant-eclipse" phase.

So at the end of the line 
      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />

we should also add:
      <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**, server/solr-webapp/**" />

Thank you.


> server/solr-webapp/** missing for the eclipse exclusions in build.xml
> ---------------------------------------------------------------------
>
>                 Key: SOLR-11014
>                 URL: https://issues.apache.org/jira/browse/SOLR-11014
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>    Affects Versions: 5.0, 6.0, 7.0
>            Reporter: Antoine Le Floc'h
>            Priority: Minor
>              Labels: build, easyfix
>
> in the top folder, in build.xml
> [https://github.com/apache/lucene-solr/blob/branch_6_6/build.xml]
> in the "eclipse" target (line 442, branch_6_6)
> {code:java}
>    <pathconvert property="eclipse.fileset.libs" pathsep="|" dirsep="/">
>       <fileset dir="${basedir}/lucene" includes="**/lib/*.jar" excludes="**/*servlet-api*.jar,
analysis/uima/**, tools/**, build/**"/>
>       <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />
>       <map from="${basedir}/" to=""/>
>     </pathconvert>
> {code}
> Just like in the netbeans target, the fileset excluded should have "server/solr-webapp/**"
also at the end.Otherwise, if I do "ant-eclipse" after "ant generate-maven-artifacts", i get
eclipse errors like:
> "The type FacetDoubleMerger is already defined	FacetModule.java	/solr6_/solr/core/src/java/org/apache/solr/search/facet
line 364"
> because
> {code:java}
> <classpathentry kind="lib" path="solr/server/solr-webapp/webapp/WEB-INF/lib/solr-core-6.6.0-SNAPSHOT.jar"/>
> {code}
> was included in my ".classpath" during the "ant-eclipse" phase.
> So at the end of the line 
> {code:java}
> <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**" />
> {code}
> we should also add:
> {code:java}
> <fileset dir="${basedir}/solr" includes="**/test-lib/*.jar,**/lib/*.jar" excludes="core/test-lib/*servlet-api*.jar,
contrib/analysis-extras/**, test-framework/lib/junit*, test-framework/lib/ant*, test-framework/lib/randomizedtesting*,
build/**, dist/**, package/**, server/solr-webapp/**" />
> {code}
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message