lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Updated] (SOLR-11055) Add 'commitWithin' testing (of both soft/hard commits) to SoftAutoCommitTest
Date Wed, 12 Jul 2017 22:19:00 GMT


Hoss Man updated SOLR-11055:
    Attachment: SOLR-11055.patch

here's a patch i'm currently testing.... seems to be working fine.

NOTE: this does make SoftAutoCommitTest take longer (because it's essentially testing 3x as
much stuff).  An alternative approach would be to refactor the test methods into the base
class, and let subclasses just declare a (static) CommitWithinType instance.  That approach
would also let us avoid the changes to DUH2: each test could just set the sysprop statically
before initCore.

> Add 'commitWithin' testing (of both soft/hard commits) to SoftAutoCommitTest 
> -----------------------------------------------------------------------------
>                 Key: SOLR-11055
>                 URL:
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>         Attachments: SOLR-11055.patch
> SoftAutoCommitTest should be enhanced with it's monitor based polling to also check that
commitWithin works just as well as autocommit maxTime for either softCommit or hardCommit
(can't test both at the same time due to how commitWithin is configured)

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message