lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7906) Spatial relationship between Geoshapes
Date Thu, 20 Jul 2017 08:18:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094338#comment-16094338
] 

Ignacio Vera commented on LUCENE-7906:
--------------------------------------

I thought it was enough with skipping the internal edges but I can reproduce the behavior
when I have a collection of shapes inside a GeoCompositeMembershipShape. 

The wrong behavior happens because of this call GeoBaseShape.isShapeInsidePolygon(final GeoShape
geoShape).

When checking in a multishape you might get SOME_INSIDE and therefore overlaps.

The Polygon to be compared should be the composite polygon and not the subcomponent so the
methods returns the correct answer ALL_INSIDE.

What it means is that either GeoConvexPolygon and GeoConcavePolygon should have a reference
to the parent composite polygon. I have implemented it and it works but it means that the
contructor for those objects need to change. Is that ok?
 

> Spatial relationship between Geoshapes
> --------------------------------------
>
>                 Key: LUCENE-7906
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7906
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-7906.patch, LUCENE-7906-test.patch
>
>
> Hi,
> Working with geosahpes and trying to resolve spatial relationships between them I came
accross a big limitation when trying to solve the relationship between two geopolygons. This
object does not expose the internal structure. In particular at some point, it is necessary
to check if one polygon intersects the edges of the other polygon which currently is not possible
as edges are not exposed.
> To be able to perform such operation it can be several options. The ones I can think
of are:
> 1) Expose the edges of the polygon ( and probably the notable points for the edges) adding
getters in the GeoPolygon interface. Easy to implement and leave users the responsability
of coding the spatial relationship.
> 2) Extends GeoPolygon interface to extends geoarea and leave the object make the spatial
relationship. 
> 3) Extends GeoShape  interface so all shapes can infer the spatial relationship with
other GeoShapes.
> I might be bias as my interest is in 2d Shapes in the unit sphere and there might be
some cases which what I propose cannot be implemented or are againts the aim of the library.
> What do you think?
> Cheers,
> Ignacio



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message