lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <>
Subject [jira] [Updated] (SOLR-10628) Less verbose output from bin/solr commands
Date Sat, 26 Aug 2017 03:56:00 GMT


Jason Gerlowski updated SOLR-10628:
    Attachment: SOLR-10628-loglevel-fix.patch

The following patch ensures that SolrCLI restores the previous log-level when it finishes
execution of any of the tools that attempt to change the log-level.  (This seemed like a better
fix than just patching the tests to force-set the correct log-level in each one).

For reviewers: the patch looks larger than the actual change, which just wraps many {{ToolBase.runImpl()}}
implementations in a try-finally, to ensure the log-level is reset properly.  The indentation
changes account for most of the diff.

Precommit and tests pass.

Still looking into the other maybe/probably-related test failure.  Don't have many theories
on that one yet.  Hope to have more time to examine it now that the weekend is here.

> Less verbose output from bin/solr commands
> ------------------------------------------
>                 Key: SOLR-10628
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: master (8.0), 7.1
>         Attachments: SOLR-10628-loglevel-fix.patch, SOLR-10628.patch, SOLR-10628.patch,
SOLR-10628.patch, SOLR-10628.patch, SOLR-10628.patch, solr_script_outputs.txt, updated_command_output.txt
> Creating a collection with {{bin/solr create}} today is too verbose:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> INFO  - 2017-05-08 09:06:54.409; org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider;
Cluster at localhost:9983 ready
> Uploading /Users/janhoy/git/lucene-solr/solr/server/solr/configsets/data_driven_schema_configs/conf
for config foo to ZooKeeper at localhost:9983
> Creating new collection 'foo' using command:
> http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&replicationFactor=1&maxShardsPerNode=1&collection.configName=foo
> {
>   "responseHeader":{
>     "status":0,
>     "QTime":4178},
>   "success":{"":{
>       "responseHeader":{
>         "status":0,
>         "QTime":2959},
>       "core":"foo_shard1_replica1"}}}
> {noformat}
> A normal user don't need all this info. Propose to move all the details to verbose mode
({{-V)}} and let the default be the following instead:
> {noformat}
> $ bin/solr create -c foo
> Connecting to ZooKeeper at localhost:9983 ...
> Created collection 'foo' with 1 shard(s), 1 replica(s) using config-set 'data_driven_schema_configs'
> {noformat}
> Error messages must of course still be verbose.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message