lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7827) disable "textgrams" when minPrefixChars=0 AnalyzingInfixSuggester
Date Mon, 07 Aug 2017 15:58:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116784#comment-16116784
] 

Adrien Grand commented on LUCENE-7827:
--------------------------------------

Protected members need javadocs because they can be accessed by users if they extend that
class. Maybe they could remain private?

> disable "textgrams" when minPrefixChars=0 AnalyzingInfixSuggester 
> ------------------------------------------------------------------
>
>                 Key: LUCENE-7827
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7827
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>         Attachments: LUCENE-7827.patch, LUCENE-7827.patch, LUCENE-7827.patch, LUCENE-7827.patch
>
>
> The current code allows to set minPrefixChars=0, but it creates an unnecessary {{textgrams}}
field, and might bring significant footprint.  Bypassing it keeps existing tests green.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message