lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Thacker (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-10719) Creating a core.properties fails if the parent of core.properties is a symlinked dierctory
Date Mon, 21 Aug 2017 08:59:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-10719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Varun Thacker updated SOLR-10719:
---------------------------------
    Fix Version/s: master (8.0)

> Creating a core.properties fails if the parent of core.properties is a symlinked dierctory
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10719
>                 URL: https://issues.apache.org/jira/browse/SOLR-10719
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>             Fix For: 7.0, 6.6.1, master (8.0)
>
>         Attachments: SOLR-10719.patch, SOLR-10719.patch
>
>
> Well, it doesn't actually fail until you try to restart the Solr instance. The root is
that creating core.properties fails.
> This is due to SOLR-8260. CorePropertiesLocator.writePropertiesFile changed from:
> propfile.getParentFile().mkdirs();
> to
> Files.createDirectories(propfile.getParent());
> The former (apparently) thinks it's OK if a symlink points to a directory, but the latter
throws an exception.
> So the behavior here is that the call appears to succeed, the replica is created and
is functional. Until you restart the instance when it's not discovered.
> I hacked in a simple test to see if the parent existed already and skip the call to createDirectories
if so and ADDREPLICA works just fine. Restarting Solr finds the replica.
> The test "for real" would probably have to be better than this as we probably really
want to keep from overwriting an existing replica and the like, didn't check whether that's
already accounted for though.
> There's another issue here that failing to write the properties file should fail the
ADDREPLICA IMO.
> [~romseygeek] I'm guessing that this is an unintended side-effect of SOLR-8260 but wanted
to check before diving in deeper.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message