lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Updated] (SOLR-11122) Creating a core should write a file first and clean up on failure
Date Wed, 16 Aug 2017 21:24:00 GMT


Erick Erickson updated SOLR-11122:
    Fix Version/s: 6.6.1

> Creating a core should write a file first and clean up on failure
> ---------------------------------------------------------------------------------
>                 Key: SOLR-11122
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>             Fix For: 7.0, 6.7, 6.6.1, master (8.0), 7.1
>         Attachments: SOLR-11122.patch, SOLR-11122.patch
> I've made the handling of more consistent as part of the pluggable transient
core work. However, a new inconsistency came to light. Most of the code assumes that a
file exists, but it wasn't being persisted until the very end of the coreContainer.create
process. So any steps part way through core creation that would manipulate the
file wouldn't find it. And if those steps did make a mistake and call persist on the,
create would fail because the file would be created. Worse, the transient
cache handler had no way of knowing whether the core descriptors being added were from create
(where the file hadn't been created yet) or reload/swap/rename. By moving
persisting the earlier in the create process this would be less trappy.
> Any file created during this process will be removed if the create fails.
> Cores that are simply being _loaded_ on the other hand do _not_ have their
files removed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message