lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11140) (private) SolrMetricManager.prepareCloudPlugins has unused parameter
Date Tue, 01 Aug 2017 10:27:02 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108688#comment-16108688
] 

ASF subversion and git services commented on SOLR-11140:
--------------------------------------------------------

Commit 9422da26e52730de5d21d52e26e52ec9c8772df5 in lucene-solr's branch refs/heads/master
from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9422da2 ]

SOLR-11140: Remove unused parameter in (private) SolrMetricManager.prepareCloudPlugins method.
(Omar Abdelnabi via Christine Poerschke)


> (private) SolrMetricManager.prepareCloudPlugins has unused parameter
> --------------------------------------------------------------------
>
>                 Key: SOLR-11140
>                 URL: https://issues.apache.org/jira/browse/SOLR-11140
>             Project: Solr
>          Issue Type: Task
>          Components: metrics
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-11140.patch
>
>
> {{SolrMetricManager.prepareCloudPlugins}} is a private method and its last parameter
({{defaultPlugin}}) is always passed in as {{null}} leading to an effectively dead/unreachable
block of code in the method implementation.
> This ticket proposes to remove the unused parameter and associated unreachable block
of code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message