lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SOLR-11140) (private) SolrMetricManager.prepareCloudPlugins has unused parameter
Date Tue, 01 Aug 2017 10:48:02 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christine Poerschke resolved SOLR-11140.
----------------------------------------
       Resolution: Fixed
         Assignee: Christine Poerschke
    Fix Version/s: 7.1
                   master (8.0)

Thanks Omar!

> (private) SolrMetricManager.prepareCloudPlugins has unused parameter
> --------------------------------------------------------------------
>
>                 Key: SOLR-11140
>                 URL: https://issues.apache.org/jira/browse/SOLR-11140
>             Project: Solr
>          Issue Type: Task
>          Components: metrics
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: master (8.0), 7.1
>
>         Attachments: SOLR-11140.patch
>
>
> {{SolrMetricManager.prepareCloudPlugins}} is a private method and its last parameter
({{defaultPlugin}}) is always passed in as {{null}} leading to an effectively dead/unreachable
block of code in the method implementation.
> This ticket proposes to remove the unused parameter and associated unreachable block
of code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message