lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-11183) why call the API end point /v2 will there ever be a /v3
Date Sun, 20 Aug 2017 04:24:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134301#comment-16134301
] 

Ishan Chattopadhyaya edited comment on SOLR-11183 at 8/20/17 4:23 AM:
----------------------------------------------------------------------

I agree with [~janhoy] and I think we should release 7.0 with {{/api}} endpoint to keep things
consistent going forward. Attaching a patch that points /api to {{/solr/__v2}} (i.e. earlier
only {{/v2}} pointed to {{/solr/__v2}}, now both do so); please review. Although I think this
is a minimal risk change (but very important to get in now), I leave it to [~anshumg]'s judgement,
though, for inclusion in 7.0.


was (Author: ichattopadhyaya):
I agree with [~janhoy] and I think we should release 7.0 with /api endpoint to keep things
consistent going forward. Attaching a patch that points /api to /solr/__v2 (i.e. earlier only
/v2 pointed to /solr/__v2, now both do so); please review. Although I think this is a minimal
risk change (but very important to get in now), I leave it to [~anshumg]'s judgement, though,
for inclusion in 7.0.

> why call the API end point /v2 will there ever be a /v3
> -------------------------------------------------------
>
>                 Key: SOLR-11183
>                 URL: https://issues.apache.org/jira/browse/SOLR-11183
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 7.1
>
>         Attachments: SOLR-11183.patch
>
>
> The mail thread
> http://lucene.472066.n3.nabble.com/v2-API-will-there-ever-be-a-v3-td4340901.html
> it makes sense to prefix v2 APIs at {{/api}} intsead of {{/v2}} if we never plan to have
a {{/v3}}
> In principle, it makes total sense
> The challenge is that it takes a while to change the code and tests to make to work.
Should this be a blocker and should we hold up the release



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message