lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7918) Give access to members of a composite shape
Date Mon, 07 Aug 2017 08:15:00 GMT


Karl Wright commented on LUCENE-7918:

Hi [~ivera], I think this looks pretty good actually.  The new API exposure is minimal, but
all public classes in geom should be annotated with "lucene-experimental" to be sure we can
change them if we need to.

Also, you have a number of unnecessary casts in GeoPolygonTest:

-    GeoPolygon polygon = (GeoPolygon)((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
+    GeoPolygon polygon = ((GeoCompositePolygon)GeoPolygonFactory.makeGeoPolygon(PlanetModel.SPHERE,
     GeoPolygon polygonConcave = GeoPolygonFactory.makeGeoConcavePolygon(PlanetModel.SPHERE,points);

There's no need to cast to a GeoPolygon; the output of makeGeoPolygon is already a GeoPolygon.

I think you're almost there; one more pass and we're good.

> Give access to members of a composite shape
> -------------------------------------------
>                 Key: LUCENE-7918
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-7918.patch
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I need to
access the members of a composite geoshape. This is currently not possible so I was wondering
if it is possible to add to more methods to the class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message