lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (LUCENE-7918) Give access to members of a composite shape
Date Thu, 10 Aug 2017 09:15:00 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ignacio Vera reopened LUCENE-7918:
----------------------------------

Hi [~daddywri],

I found an small issue with the composite shapes. I think this issue existed before so not
sure if the behavior is intended. The problem comes from the way equality is defined in GeoBaseCompositeShape,
in particular the return in line 119:

<code>
return super.equals(o) && shapes.equals(other.shapes);
</code>

I think the call to the parent class should be removed or equals will only return true if
it is the same instance:


<code>
return shapes.equals(other.shapes);
</code>

What do you think?

Cheers,

I.



   

> Give access to members of a composite shape
> -------------------------------------------
>
>                 Key: LUCENE-7918
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7918
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>             Fix For: 6.6, master (8.0), 7.1
>
>         Attachments: LUCENE-7918.patch
>
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I need to
access the members of a composite geoshape. This is currently not possible so I was wondering
if it is possible to add to more methods to the class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message