lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11206) Migrate logic from bin/solr scripts to SolrCLI
Date Fri, 18 Aug 2017 02:25:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Gerlowski updated SOLR-11206:
-----------------------------------
    Attachment: ctrl-script-output-benchmark.cmd
                windows-initial-output.txt

Attaching the "benchmark" I was putting together on Windows.

> Migrate logic from bin/solr scripts to SolrCLI
> ----------------------------------------------
>
>                 Key: SOLR-11206
>                 URL: https://issues.apache.org/jira/browse/SOLR-11206
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>            Reporter: Jason Gerlowski
>             Fix For: master (8.0)
>
>         Attachments: ctrl-script-output-benchmark.cmd, ctrl-script-output-benchmark.sh,
linux-initial-output.txt, SOLR-11206.patch, windows-initial-output.txt
>
>
> The {{bin/solr}} and {{bin/solr.cmd}} scripts have taken on a lot of logic that would
be easier to maintain if it was instead written in Java code, for a handful of reasons
> * Any logic in the control scripts is duplicated in two places by definition.
> * Increasing test coverage of this logic would be much easier if it was written in Java.
> * Few developers are conversant in both bash and Windows-shell, making editing difficult.
> Some sections in these scripts make good candidates for migration to Java.  This issue
should examine any of these that are brought up.  However the biggest and most obvious candidate
for migration is the argument parsing, validation, usage/help text, etc. for the commands
that don't directly start/stop Solr processes (i.e. the "create", "delete", "zk", "auth",
"assert" commands).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message