lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Yano (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-11223) expand TestLTROnSolrCloud test coverage
Date Mon, 14 Aug 2017 01:16:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125116#comment-16125116
] 

Yuki Yano edited comment on SOLR-11223 at 8/14/17 1:15 AM:
-----------------------------------------------------------

[~cpoerschke]
It seems that the second patch needs to specify the name of featureStore for transforming.

By default, it tries to extract featureStore named "_DEFAULT_". On the other hand, this test
case register featureStore as "test".
https://github.com/apache/lucene-solr/blob/master/solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java#L240

Thus, we can fix this test case by adding {{store=test}} to {{fl}} params like below.
{code:java}
query.setFields("*,score,features:[fv store=test]");
{code}


was (Author: yuyano):
[~cpoerschke]
It seems that the second patch needs to specify the name of featureStore for transforming.

By default, it tries to extract featureStore named {{_DEFAULT_}}. On the other hand, this
test case register featureStore as {{test}}.
https://github.com/apache/lucene-solr/blob/master/solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java#L240

Thus, we can fix this test case by adding {{store=test}} to {{fl}} params like below.
{code:java}
query.setFields("*,score,features:[fv store=test]");
{code}

> expand TestLTROnSolrCloud test coverage
> ---------------------------------------
>
>                 Key: SOLR-11223
>                 URL: https://issues.apache.org/jira/browse/SOLR-11223
>             Project: Solr
>          Issue Type: Test
>          Components: contrib - LTR
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-11223-part1.patch, SOLR-11223-part2.patch
>
>
> * part 1: do asserts on all 8 results (this will help with test clarity i think)
> * part 2: test 'feature vector returned' not only with re-ranking but also without re-ranking



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message