lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Braun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11242) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance
Date Wed, 16 Aug 2017 03:59:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128272#comment-16128272
] 

Michael Braun commented on SOLR-11242:
--------------------------------------

Verified latest version 7.0.2 does not change this issue. Will submit a patch to make this
exception static since the stacktrace is not used and one instance of the exception can be
shared for all instances of the parser.

> QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-11242
>                 URL: https://issues.apache.org/jira/browse/SOLR-11242
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0, 6.6.1, master (8.0)
>            Reporter: Michael Braun
>         Attachments: SOLR-11242.png
>
>
> Sampling of an application which includes a very heavy query load testing against an
EmbeddedSolrServer reveals a huge amount of the time spent on initialization of the QueryParser
itself, specifically an internal class called LookaheadSuccess which extends from Error. With
every instance of QueryParser created, it spends time populating the stacktrace for this object,
which is created as a final instance variable (the variable called jj_ls). 
> Ideally an exception shouldn't be used as a signaling mechanism, or at the very least,
not an exception created on every single object instantiation. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message