lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <>
Subject [jira] [Updated] (SOLR-11250) Add new LTR model which loads the model definition from the external resource
Date Thu, 17 Aug 2017 21:03:00 GMT


Christine Poerschke updated SOLR-11250:
    Attachment: SOLR-11250.patch

[~yuyano] - thank you for creating this ticket and the attached patch!

Based on your patch, I'm attaching a revised patch with suggested changes as follows:
* avoid introducing a dependency whereby solr.ltr.model starts to depend on
by relocating the 'loadModel' functionality into the ManagedModelStore which is already loading
non-external models
* permit but warn about external models wrapping other external models (code change only,
not yet adjusted the test)
* removed the need for a dummy feature and norm in ExternalModel (some validate TODOs still
* (not yet included but would be good to have i think) TestExternalModel.testDeclaredMethodsOverridden
similar to TestFilterWeight.testDeclaredMethodsOverridden to test that the ExternalModel class
really does delegate all method calls

What do you think?

> Add new LTR model which loads the model definition from the external resource
> -----------------------------------------------------------------------------
>                 Key: SOLR-11250
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: contrib - LTR
>            Reporter: Yuki Yano
>            Priority: Minor
>         Attachments: SOLR-11250_master.patch, SOLR-11250.patch
> We add new model which contains only the location of the external model and loads it
during the initialization.
> By this procedure, large models which are difficult to upload to ZooKeeper can be available.
> The new model works as the wrapper of existing models, and deligates APIs to them.
> We add two classes by this patch:
> * {{ExternalModel}} : a base class for models with external resources.
> * {{URIExternalModel}} : an implementation of {{ExternalModel}} which loads the external
model from specified URI (ex. file:, http:, etc.).
> For example, if you have a model on the local disk "file:///var/models/myModel.json",
the definition of {{URIExternalModel}} will be like the following.
> {code}
> {
>   "class" : "org.apache.solr.ltr.model.URIExternalModel",
>   "name" : "myURIExternalModel",
>   "features" : [],
>   "params" : {
>     "uri" : "file:///var/models/myModel.json"
>   }
> }
> {code}
> If you use LTR with {{model=myURIExternalModel}}, the model of {{myModel.json}} will
be used for scoring documents.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message