lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11256) Provide default for ConcurrentUpdateSolrClient's "queueSize" param
Date Fri, 18 Aug 2017 03:00:10 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Gerlowski updated SOLR-11256:
-----------------------------------
    Attachment: SOLR-11256.patch

Attached is a patch with 10 as the default queueSize.  Documented in the Javadocs.

Tests and precommit pass.

> Provide default for ConcurrentUpdateSolrClient's "queueSize" param
> ------------------------------------------------------------------
>
>                 Key: SOLR-11256
>                 URL: https://issues.apache.org/jira/browse/SOLR-11256
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: master (8.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>         Attachments: SOLR-11256.patch
>
>
> A user on the mailing list recently pointed out that if it's not specified explicitly
as a Builder option, ConcurrentUpdateSolrClient will default to using a queueSize of 0.  This
value gets passed in to the underlying queue data structure which throws an IllegalArgumentException,
with an error message that isn't obvious to those unfamiliar with the internals.
> We should provide a better default than the uninitialized-variable default of 0.  Almost
all occurrences in the code fall between 5 and 10, so a queueSize in that range should be
uncontroversial.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message