lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Won Jonghoon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size
Date Sun, 20 Aug 2017 11:53:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134402#comment-16134402
] 

Won Jonghoon commented on LUCENE-7933:
--------------------------------------

I agree it.


It just seems to add size checking logic.








--------- 원본 메일 ---------


보낸사람: Michael McCandless (JIRA) <jira@apache.org>
받는사람: <k9200544@hanmail.net>
날짜: 17.08.20 18:46 GMT +0900
제목: [jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size


    [ [1]https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134359#comment-16134359 ] 

Michael McCandless commented on LUCENE-7933:
--------------------------------------------

Let's just add a check in the ctor and throw {{IllegalArgumentException}} if the request {{numBits}} is too large?




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)




----------------------------------------------------------------------------------------
[1] https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134359#comment-16134359
[2] https://issues.apache.org/jira/browse/LUCENE-7933
----------------------------------------------------------------------------------------
[1] https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134359#comment-16134359
[2] https://issues.apache.org/jira/browse/LUCENE-7933


> LongBistSet can't have Long size
> --------------------------------
>
>                 Key: LUCENE-7933
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7933
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 6.6
>            Reporter: Won Jonghoon
>            Priority: Trivial
>
> private final long[] bits; // Array of longs holding the bits 
> ===> bits.length is small for bit number having Long.MAX
> so you can not call "LongBitSet.set(Long.MAX-1)"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message