lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7936) Extend Geoshape interfaces so objects can be copied/serialized
Date Wed, 23 Aug 2017 10:12:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138190#comment-16138190
] 

Karl Wright commented on LUCENE-7936:
-------------------------------------

My thought is that we can explicitly choose to serialize the planet model exactly ONCE, should
we want to do that, rather than inside of every point and shape.  We also don't have to serialize
class names EXCEPT when they can be ambiguous.  To GeoPoint, I will be adding read/write methods
for strings and for SerializedObjects.  I think we still need a separate place for static
methods to support serialization/deserialization to live -- maybe in the SerializedObject
interface itself, rather than in GeoPoint?  We can supposedly do that now with Java 8 -- although
I'd really not want them to be visible outside the package if possible.

I have *zero* time today and most of tomorrow but if this looks promising please wait on implementing
serialization until I'm ready.  Tile iteration you can go ahead with.  Thanks!


> Extend Geoshape interfaces so objects can be copied/serialized
> --------------------------------------------------------------
>
>                 Key: LUCENE-7936
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7936
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: GeoBinaryCodec.patch, LUCENE-7936.patch, LUCENE-7936.patch, Spatial4j.patch
>
>
> Hi [~david.wright@bksv.com],
> I would like to propose to extends the GeoShape interfaces to be able to copy/serialized
the objects. The current status and  propose change is as following:
> GeoPoint: It can be serialized by using x, y, z
> GeoCircle:  It can be serialized by using getCenter() and getRadius() and getPlanetModel()
> GeoCompositeShape: It can be serialized by accesing shapes using size() and GetShape(int
index)
> GeoPath: add methods to the interface getPoints() and getCutoffAngle()
> GeoPolygon: This is the most complicated one as we have different types:
>    1.- GeoCompositePolygon is just a composite
>    2.- GeoConcavePolygon and GeoConvexPolygon: Create a new interface for those polygons
which exposes the points, holes, internaledges and concavity/convexity
>    3.- GeoComplexPolygons: Do nothing, they are too complex to be serialize??
> I am intersested in accesing the discreatization of the polygons into convex and concave
ones for other reasons as well. I think this should be expose as they end result can be used
for other use cases.
> Cheers,
> I.
>   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message