lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7936) Extend Geoshape interfaces so objects can be copied/serialized
Date Tue, 29 Aug 2017 13:21:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145268#comment-16145268
] 

Ignacio Vera commented on LUCENE-7936:
--------------------------------------

I have actually changed my mind. The first option is so much cleaner to implement and it is
totally generic and the extra byte does not generate noticable difference in performance (as
expected). 

I do not like so much the complexity added by option 2. 

What do you think?



> Extend Geoshape interfaces so objects can be copied/serialized
> --------------------------------------------------------------
>
>                 Key: LUCENE-7936
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7936
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>             Fix For: 6.7, master (8.0), 7.1
>
>         Attachments: factory.patch, GeoBinaryCodec.patch, LUCENE-7936-GeoComplexPolygon.patch,
LUCENE-7936.patch, LUCENE-7936.patch, LUCENE-7936.patch, LUCENE-7936-test.patch, Spatial4j.patch
>
>
> Hi [~david.wright@bksv.com],
> I would like to propose to extends the GeoShape interfaces to be able to copy/serialized
the objects. The current status and  propose change is as following:
> GeoPoint: It can be serialized by using x, y, z
> GeoCircle:  It can be serialized by using getCenter() and getRadius() and getPlanetModel()
> GeoCompositeShape: It can be serialized by accesing shapes using size() and GetShape(int
index)
> GeoPath: add methods to the interface getPoints() and getCutoffAngle()
> GeoPolygon: This is the most complicated one as we have different types:
>    1.- GeoCompositePolygon is just a composite
>    2.- GeoConcavePolygon and GeoConvexPolygon: Create a new interface for those polygons
which exposes the points, holes, internaledges and concavity/convexity
>    3.- GeoComplexPolygons: Do nothing, they are too complex to be serialize??
> I am intersested in accesing the discreatization of the polygons into convex and concave
ones for other reasons as well. I think this should be expose as they end result can be used
for other use cases.
> Cheers,
> I.
>   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message