lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11281) SolrSlf4jReporterTest fails on jenkins
Date Sat, 26 Aug 2017 12:17:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Gerlowski updated SOLR-11281:
-----------------------------------
    Attachment: SOLR-11281.patch

I second Hoss's opinion that 10628 is at fault here.  A bug was introduced in the JIRA whereby
SolrCLI many {{runTool}} calls will change the log-level of the JVM to WARN, without resetting
it when done.  (I've uploaded a patch fixing this issue over there).

This seems to affect SolrSlf4jReporterTest.  My guess is that it expects to find logs reported,
but when the test is executed with an elevated log-level, nothing actually gets logged.  This
is supported by the fact that if you add the following code to SolrSlf4jReporterTest, it fails
consistently with the same error message noted above.

{code}
  @BeforeClass
  public static void beforeItAll() throws Exception {
    StartupLoggingUtils.changeLogLevel("WARN"); 
  }
{code}
Merging the patch on SOLR-10628 should resolve this issue.  To address Hoss's point, I've
attached a patch containing a {{BeforeClass}} check with a nice error message, to ensure the
log level is what the test expects/requires.

> SolrSlf4jReporterTest fails on jenkins
> --------------------------------------
>
>                 Key: SOLR-11281
>                 URL: https://issues.apache.org/jira/browse/SOLR-11281
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Minor
>             Fix For: master (8.0), 7.1
>
>         Attachments: SOLR-11281.patch
>
>
> This test fails frequently on jenkins with a failed assertion:
> {code}
> FAILED:  org.apache.solr.metrics.reporters.SolrSlf4jReporterTest.testReporter
> Error Message:
> Stack Trace:
> java.lang.AssertionError
> 	at __randomizedtesting.SeedInfo.seed([7B977D6F04FCA50C:247350586FF03649]:0)
> 	at org.junit.Assert.fail(Assert.java:92)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.junit.Assert.assertTrue(Assert.java:54)
> 	at org.apache.solr.metrics.reporters.SolrSlf4jReporterTest.testReporter(SolrSlf4jReporterTest.java:84)
> {code}
> A better failure message is needed first, then the test needs a fix to be more robust.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message