lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Fri, 25 Aug 2017 14:18:00 GMT


Karl Wright commented on LUCENE-7941:

[~ivera], the contract for "intersects" means that it must return true if there is intersection
between the plane and the shape, within the bounds given.  A point lying on the plane clearly
intersects it.  So that logic is right.  The error must be elsewhere.

I notice this code:

  public boolean intersects(GeoShape geoShape) {
    return false;

That seems incorrect to me.  I would think you'd want to call geoShape.within() here.  Can
you explain why a GeoDegeneratePoint should never be considered to intersect?

> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>                 Key: LUCENE-7941
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7941-test.patch
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message