lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Fri, 25 Aug 2017 14:18:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141680#comment-16141680
] 

Karl Wright commented on LUCENE-7941:
-------------------------------------

[~ivera], the contract for "intersects" means that it must return true if there is intersection
between the plane and the shape, within the bounds given.  A point lying on the plane clearly
intersects it.  So that logic is right.  The error must be elsewhere.

I notice this code:

{code}
  @Override
  public boolean intersects(GeoShape geoShape) {
    return false;
  }
{code}

That seems incorrect to me.  I would think you'd want to call geoShape.within() here.  Can
you explain why a GeoDegeneratePoint should never be considered to intersect?


> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7941
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7941-test.patch
>
>
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message