lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Fri, 25 Aug 2017 15:19:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141752#comment-16141752
] 

Ignacio Vera commented on LUCENE-7941:
--------------------------------------

[~daddywri], this is exactly the discussion I wanted to rise.

The contract of intersects(GeoShape geoShape) says: "Assess whether a shape intersects with
any of the edges this shape." Therefore the current implementation is valid as there is no
edges in GeoDegeneratedPoint.

Respect the other intersects method, the key lies in the word "shape". We are trying to make
a point behave like a shape. It does not make sense that a point shape intersects a plane
of another shape and the spatial relationship is WITHIN/CONTAINS. But I see that the getRelationship
contract says:

"t is permissible to return OVERLAPS instead of WITHIN if the shape intersects with the area
at even a single point."

I would say that overlaps should be better than within. Therefore point shapes should return
OVERLAPS if they lay in an edge. 

Make sense?

> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7941
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7941-test.patch
>
>
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message