lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Fri, 25 Aug 2017 16:49:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141857#comment-16141857
] 

Karl Wright edited comment on LUCENE-7941 at 8/25/17 4:48 PM:
--------------------------------------------------------------

[~ivera], I think what you are trying to say is that this method in GeoDegenerateShape:

{code}
  @Override
  public boolean intersects(GeoShape geoShape) {
    return false;
  }
{code}

... cannot be properly computed because we have no general way to do it, other than implement
something special for all GeoAreaShapes when they intersect with points.  I see what you are
trying to do to work around this issue.

I wonder what would happen if we extend the contract for this method to allow a "true" return
for *either* an intersection with an edge, but *also* for anything wholly within the shape,
if the former is too hard to compute?  Then you could use geoShape.isWithin().  Would that
yield sensible values for getRelationship()?

I'll try to think about this further while I'm offline.


was (Author: kwright@metacarta.com):
[~ivera], I think what you are trying to say is that this method in GeoDegenerateShape:

{code}
  @Override
  public boolean intersects(GeoShape geoShape) {
    return false;
  }
{code}

... cannot be properly computed because we have no general way to do it, other than implement
something special for all GeoAreaShapes when they intersect with points.  I see what you are
trying to do to work around this issue.

I wonder what would happen if we extend the contract for this method to allow a "true" return
for *either* an intersection with an edge, but *also* for anything wholly within the shape,
if the former is too hard to compute?  Then you could use geoShape.isWithin().  Would that
yield sensible values for getRelationship()?
 

> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7941
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7941-test.patch
>
>
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message