lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Sat, 26 Aug 2017 09:40:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142728#comment-16142728
] 

Ignacio Vera commented on LUCENE-7941:
--------------------------------------

Hi [~daddywri],

I think actually the implementation of geoDegeneratePoint complies with the contract as it
return CONTAINS/OVERLAPS (instead of WITHIN according to contract) when the geoDegeneratePoint
lies in the boundary of the other shape .

On the other hand, the implementation of other shapes might  be not fully complaint as any
shape that has a point in an edge of another shape will always return OVERLAPS/OVERLAPS. 
Therefore a circle inscribed in a rectangle will return OVERLAPS/OVERLAPS.

If this is acceptable, then there is nothing to be done.

What it might be missing is a method in the the Plane; crossPlane(Plane lane,...) very similar
to intersects but only return trues if intersects  and  has points in both sides of the other
plane. With that functionaly the method getRelationship() can be more accurate according to
contract.
 
Thanks!

 

> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7941
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>             Fix For: 6.7, master (8.0), 7.1
>
>         Attachments: LUCENE-7941-test.patch
>
>
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message