lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7946) CharTermAttributeImpl.setLength missing bounds check
Date Thu, 31 Aug 2017 06:43:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148529#comment-16148529
] 

Uwe Schindler commented on LUCENE-7946:
---------------------------------------

In Java 9 we should use the new Objects methods for bounds checking! http://download.java.net/java/jdk9/docs/api/java/util/Objects.html#checkIndex-int-int-
Those are better optimized.

> CharTermAttributeImpl.setLength missing bounds check
> ----------------------------------------------------
>
>                 Key: LUCENE-7946
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7946
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>         Attachments: LUCENE-7946.patch
>
>
> CharTermAttribute.setLength partially checks for out of bounds values (exceeds term buffer
array size) but doesn't check for negative values.
> This can be confusing as then the negative length will only fail or misbehave much later,
for example with the first iteration of LUCENE-7940. It fails later only when we call toString()
afterwards.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message