lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7736) Expose some IndexReader stats via DoubleValuesSources
Date Thu, 19 Oct 2017 13:53:00 GMT


Adrien Grand commented on LUCENE-7736:

Your point about using the description for equals is correct, but I still find it fragile.
I think it's important for equals to behave correctly and never return true for values sources
that could return different values.

Looking again at the patch, I think you forgot to update FunctionMatchQuery to make it rewrite
the values source?

bq. I really dislike the 'rewrite until things stay the same' API on Query...

Let's open an issue about fixing it?

> Expose some IndexReader stats via DoubleValuesSources
> -----------------------------------------------------
>                 Key: LUCENE-7736
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-7736.patch, LUCENE-7736.patch, LUCENE-7736.patch, LUCENE-7736.patch,
> We have a number of ValueSource implementations that expose IndexReader stats (numDocs,
termFreq, etc).  We should re-implement these as DoubleValuesSources, allowing them to be
used in FunctionScoreQuery, etc.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message