lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mano Kovacs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10912) Adding automatic patch validation
Date Mon, 02 Oct 2017 23:20:02 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189033#comment-16189033
] 

Mano Kovacs commented on SOLR-10912:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m 00s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 00s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} Check examples refer correct lucene version {color}
| {color:green}  0m 06s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 06s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  0m
06s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}  0m 06s{color}
| {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}255m 09s{color} | {color:red}
core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 11s{color} | {color:red}
solrj in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}272m 02s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.analysis.TestWordDelimiterFilterFactory |
|   | solr.cloud.CdcrBootstrapTest |
|   | solr.cloud.DeleteStatusTest |
|   | solr.cloud.FullSolrCloudDistribCmdsTest |
|   | solr.cloud.hdfs.HdfsCollectionsAPIDistributedZkTest |
|   | solr.cloud.LeaderElectionIntegrationTest |
|   | solr.cloud.ShardRoutingTest |
|   | solr.cloud.ShardSplitTest |
|   | solr.cloud.SharedFSAutoReplicaFailoverUtilsTest |
|   | solr.cloud.SyncSliceTest |
|   | solr.cloud.TestHdfsCloudBackupRestore |
|   | solr.cloud.TestLeaderElectionWithEmptyReplica |
|   | solr.cloud.TestLocalFSCloudBackupRestore |
|   | solr.cloud.TestTolerantUpdateProcessorCloud |
|   | solr.cloud.UnloadDistributedZkTest |
|   | solr.core.TestCorePropertiesReload |
|   | solr.core.TestCustomStream |
|   | solr.core.TestInfoStreamLogging |
|   | solr.core.TestSimpleTextCodec |
|   | solr.core.TestSolrDeletionPolicy1 |
|   | solr.handler.loader.JavabinLoaderTest |
|   | solr.handler.TestSolrConfigHandlerCloud |
|   | solr.handler.V2StandaloneTest |
|   | solr.handler.XsltUpdateRequestHandlerTest |
|   | solr.highlight.TestPostingsSolrHighlighter |
|   | solr.internal.csv.CharBufferTest |
|   | solr.internal.csv.CSVUtilsTest |
|   | solr.metrics.JvmMetricsTest |
|   | solr.MinimalSchemaTest |
|   | solr.schema.DateFieldTest |
|   | solr.schema.MultiTermTest |
|   | solr.schema.PolyFieldTest |
|   | solr.schema.TestBinaryField |
|   | solr.schema.TestBulkSchemaConcurrent |
|   | solr.schema.TestManagedSchema |
|   | solr.schema.UUIDFieldTest |
|   | solr.search.AnalyticsMergeStrategyTest |
|   | solr.search.function.distance.DistanceFunctionTest |
|   | solr.search.similarities.TestPerFieldSimilarity |
|   | solr.search.TestPayloadScoreQParserPlugin |
|   | solr.search.TestSolrJ |
|   | solr.servlet.DirectSolrConnectionTest |
|   | solr.servlet.HttpSolrCallGetCoreTest |
|   | solr.spelling.SpellingQueryConverterTest |
|   | solr.spelling.suggest.SuggesterTest |
|   | solr.spelling.suggest.TestHighFrequencyDictionaryFactory |
|   | solr.spelling.suggest.TestPhraseSuggestions |
|   | solr.TestHighlightDedupGrouping |
|   | solr.util.CircularListTest |
|   | solr.util.FileUtilsTest |
|   | solr.util.PrimUtilsTest |
|   | solr.util.TestUtils |
|   | solr.client.solrj.io.stream.StreamExpressionTest |
|   | solr.common.cloud.TestCollectionStateWatchers |
|   | solr.analysis.TestWordDelimiterFilterFactory |
|   | solr.cloud.CdcrBootstrapTest |
|   | solr.cloud.DeleteStatusTest |
|   | solr.cloud.FullSolrCloudDistribCmdsTest |
|   | solr.cloud.hdfs.HdfsCollectionsAPIDistributedZkTest |
|   | solr.cloud.LeaderElectionIntegrationTest |
|   | solr.cloud.ShardRoutingTest |
|   | solr.cloud.ShardSplitTest |
|   | solr.cloud.SharedFSAutoReplicaFailoverUtilsTest |
|   | solr.cloud.SyncSliceTest |
|   | solr.cloud.TestHdfsCloudBackupRestore |
|   | solr.cloud.TestLeaderElectionWithEmptyReplica |
|   | solr.cloud.TestLocalFSCloudBackupRestore |
|   | solr.cloud.TestTolerantUpdateProcessorCloud |
|   | solr.cloud.UnloadDistributedZkTest |
|   | solr.core.TestCorePropertiesReload |
|   | solr.core.TestCustomStream |
|   | solr.core.TestInfoStreamLogging |
|   | solr.core.TestSimpleTextCodec |
|   | solr.core.TestSolrDeletionPolicy1 |
|   | solr.handler.loader.JavabinLoaderTest |
|   | solr.handler.TestSolrConfigHandlerCloud |
|   | solr.handler.V2StandaloneTest |
|   | solr.handler.XsltUpdateRequestHandlerTest |
|   | solr.highlight.TestPostingsSolrHighlighter |
|   | solr.internal.csv.CharBufferTest |
|   | solr.internal.csv.CSVUtilsTest |
|   | solr.metrics.JvmMetricsTest |
|   | solr.MinimalSchemaTest |
|   | solr.schema.DateFieldTest |
|   | solr.schema.MultiTermTest |
|   | solr.schema.PolyFieldTest |
|   | solr.schema.TestBinaryField |
|   | solr.schema.TestBulkSchemaConcurrent |
|   | solr.schema.TestManagedSchema |
|   | solr.schema.UUIDFieldTest |
|   | solr.search.AnalyticsMergeStrategyTest |
|   | solr.search.function.distance.DistanceFunctionTest |
|   | solr.search.similarities.TestPerFieldSimilarity |
|   | solr.search.TestPayloadScoreQParserPlugin |
|   | solr.search.TestSolrJ |
|   | solr.servlet.DirectSolrConnectionTest |
|   | solr.servlet.HttpSolrCallGetCoreTest |
|   | solr.spelling.SpellingQueryConverterTest |
|   | solr.spelling.suggest.SuggesterTest |
|   | solr.spelling.suggest.TestHighFrequencyDictionaryFactory |
|   | solr.spelling.suggest.TestPhraseSuggestions |
|   | solr.TestHighlightDedupGrouping |
|   | solr.util.CircularListTest |
|   | solr.util.FileUtilsTest |
|   | solr.util.PrimUtilsTest |
|   | solr.util.TestUtils |
|   | solr.client.solrj.io.stream.StreamExpressionTest |
|   | solr.common.cloud.TestCollectionStateWatchers |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-10912 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12889953/SOLR-10912.ok-patch-in-core.patch
|
| Optional Tests |  javac  unit  |
| uname | Darwin manomac.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT
2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64 |
| Build tool | ant |
| Personality | /Users/manokovacs/repos/solr-yetus/dev-tools/test-patch/solr-yetus-personality.sh
|
| git revision | master / 266cc82df0 |
| Default Java | 1.8.0_101 |
| unit | artifact/patchprocess/patch-unit-solr_core.txt |
| unit | artifact/patchprocess/patch-unit-solr_solrj.txt |
| modules | C: solr/core solr/solrj U: solr |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Adding automatic patch validation
> ---------------------------------
>
>                 Key: SOLR-10912
>                 URL: https://issues.apache.org/jira/browse/SOLR-10912
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Mano Kovacs
>         Attachments: SOLR-10912.ok-patch-in-core.patch, SOLR-10912.sample-patch.patch,
SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or other Apache
projects are using (see link). This would ensure that every patch passes a certain set of
criterions before getting approved. It would save time for developer (faster feedback loop),
save time for committers (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be a good direction
to start. This jira could be the board of discussing the preferred solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message