lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11380) SolrJ must stream docs to server instead of writing to a byte[] first
Date Tue, 31 Oct 2017 14:20:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226867#comment-16226867
] 

David Smiley commented on SOLR-11380:
-------------------------------------

Sorry I'm still confused.  Is there an actual point to the "if" condition with code duplication?
 I don't see how what you're saying explains how the code needs to be the way it is -- how
it can't be simplified.  I can't imagine how in _any_ circumstance that it has a semantic
difference with the simplified replacement.  If it does, man you have stumped me badly and
I want to learn!  Perhaps chat with me on IRC "dsmiley"; I want to understand this.  If it
can be replaced and tests pass / semantically equivalent, then I think we should do so.  Otherwise,
it needs comments on how this code needs to be this way.

BTW thanks for doing this issue -- I love it when we can stream data more instead of wasteful
buffering!

> SolrJ must stream docs to server instead of writing to a byte[] first 
> ----------------------------------------------------------------------
>
>                 Key: SOLR-11380
>                 URL: https://issues.apache.org/jira/browse/SOLR-11380
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 7.2, master (8.0)
>
>         Attachments: SOLR-11380.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message