lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7983) Make IndexReaderWarmer a functional interface
Date Sat, 07 Oct 2017 07:45:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195600#comment-16195600
] 

ASF subversion and git services commented on LUCENE-7983:
---------------------------------------------------------

Commit 81e4e80190afb8bd18e1d1fd955e7a401a45013c in lucene-solr's branch refs/heads/branch_7x
from [~dawid.weiss]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=81e4e80 ]

LUCENE-7983: IndexWriter.IndexReaderWarmer is now a functional interface instead of an abstract
class with a single method.


> Make IndexReaderWarmer a functional interface
> ---------------------------------------------
>
>                 Key: LUCENE-7983
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7983
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 7.1
>
>
> {{IndexReaderWarmer}} has a single method but is an abstract class with a confusing protected
constructor. Can we make it a proper functional interface instead? This is marked as {{lucene.experimental}}
API and while it would be a binary incompatibility, everything remains the same at the source
level, even for existing implementations.
> {code}
> public static abstract class IndexReaderWarmer {
>     /** Sole constructor. (For invocation by subclass 
>      *  constructors, typically implicit.) */
>     protected IndexReaderWarmer() {
>     }
>     /** Invoked on the {@link LeafReader} for the newly
>      *  merged segment, before that segment is made visible
>      *  to near-real-time readers. */
>     public abstract void warm(LeafReader reader) throws IOException;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message