lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11460) review <luceneMatchVersion> values used in test-files
Date Tue, 10 Oct 2017 17:16:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198995#comment-16198995
] 

Steve Rowe commented on SOLR-11460:
-----------------------------------

FYI the {{dev-tools/scripts/addVersion.py}} script, which is run by L/S release managers,
updates the {{<luceneMatchVersion>}} in example configs - maybe it should do the same
in test configs too?:

{code}
def update_example_solrconfigs(new_version):
  print('  updating example solrconfig.xml files')
  matcher = re.compile('<luceneMatchVersion>')

  paths = ['solr/server/solr/configsets', 'solr/example', 'solr/core/src/test-files/solr/configsets/_default']
  for path in paths:
    if not os.path.isdir(path):
      raise RuntimeError("Can't locate configset dir (layout change?) : " + path)
    for root,dirs,files in os.walk(path, onerror=onerror):
      for f in files:
        if f == 'solrconfig.xml':
          update_solrconfig(os.path.join(root, f), matcher, new_version)
{code}

For test files it could be more sophisticated than the above, e.g. to only update numeric
versions and leave expressions involving {{LATEST}} as-is.

> review <luceneMatchVersion> values used in test-files
> -----------------------------------------------------
>
>                 Key: SOLR-11460
>                 URL: https://issues.apache.org/jira/browse/SOLR-11460
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> Noticed that different test files use (unexpectedly) different {{<luceneMatchVersion>}}
values. Details to follow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message