lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
Date Sun, 15 Oct 2017 16:00:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205169#comment-16205169
] 

David Smiley commented on SOLR-11464:
-------------------------------------

The code here hasn't been changed substantially from SOLR-4997 (shard split) by [~shalinmangar].
 Shalin do you think there are side effects from these lines or should we just refactor them
as Gus suggests?  If they need to be there, obviously there should be explicit comments to
this effect.  Since such comments don't exist, I'm inclined to think Gus's simple refactoring
is safe.

> Unused code in DistributedUpdateProcessor
> -----------------------------------------
>
>                 Key: SOLR-11464
>                 URL: https://issues.apache.org/jira/browse/SOLR-11464
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: master (8.0)
>            Reporter: Gus Heck
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: SOLR-11464.patch, unused.png
>
>
> While reading code I ran across a couple of suspicious unused values/variables. Thought
I would raise this so that folks can consider if something was lost here, or if perhaps we
can eliminate an unnecessary call to zookeeper and tidy things up a bit. Screenshot and patch
to eliminate shortly...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message