lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cao Manh Dat (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11469) LeaderElectionContextKeyTest has flawed logic: 50% of the time it checks the wrong shard's elections
Date Wed, 25 Oct 2017 02:11:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217988#comment-16217988
] 

Cao Manh Dat commented on SOLR-11469:
-------------------------------------

[~hossman] Yeah, It seems a good idea. If someone changes low-level implementation that causes
test's assumption invalid, the test must be failed 100%

> LeaderElectionContextKeyTest has flawed logic: 50% of the time it checks the wrong shard's
elections
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-11469
>                 URL: https://issues.apache.org/jira/browse/SOLR-11469
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Cao Manh Dat
>             Fix For: 7.2, master (8.0)
>
>         Attachments: SOLR-11469.patch, SOLR-11469.patch, SOLR-11469_incomplete_and_broken.patch
>
>
> LeaderElectionContextKeyTest is very flaky -- and on millers beastit reports it shows
a suspiciously close to "50%" failure rate.
> Digging into the test i realized that it creates a 2 shard index, then picks "a leader"
to kill (arbitrarily) and then asserts that the leader election nodes for *shard1* are affected
... so ~50% of the time it kills the shard2 leader and then fails because it doesn't see an
election in shard1.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message