lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpountz <...@git.apache.org>
Subject [GitHub] lucene-solr issue #280: LUCENE-8011: Improve similarity explanations
Date Fri, 01 Dec 2017 08:37:41 GMT
Github user jpountz commented on the issue:

    https://github.com/apache/lucene-solr/pull/280
  
    Thanks @mayya-sharipova, this looks like great progress to me. Maybe we could go even
further and do the following:
     - in the Axiomatic similarity, add abstract methods to allow sub classes to explain how
tf, ln, etc. are computed,
     - make BasicModel.explain abstract to force sub classes to have their own explanation
and include the formula,
     - make sure that our own sub classes of SimilarityBase extend explain (the one that returns
an explanation) and include the formula in the explanation.
    
    For the record, there is not too much concern to have about backward compatibility since
most of those classes (eg. Axiomatic, BasicModel) are very expert classes and this changes
targets master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message