lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11336) DocBasedVersionConstraintsProcessor should be more extensible
Date Fri, 01 Dec 2017 16:16:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274574#comment-16274574
] 

David Smiley commented on SOLR-11336:
-------------------------------------

bq. As the next step I want to extend it to process multiple versions at once - this fair
to do as part of this?

+1

> DocBasedVersionConstraintsProcessor should be more extensible
> -------------------------------------------------------------
>
>                 Key: SOLR-11336
>                 URL: https://issues.apache.org/jira/browse/SOLR-11336
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Michael Braun
>            Priority: Minor
>         Attachments: SOLR-11336.patch
>
>
> DocBasedVersionConstraintsProcessor supports allowing document updates only if the new
version is greater than the old. However, if any behavior wants to be extended / changed in
minor ways, the entire class will need to be copied and slightly modified rather than extending
and changing the method in question. 
> It would be nice if DocBasedVersionConstraintsProcessor stood on its own as a non-private
class. In addition, certain methods (such as pieces of isVersionNewEnough) should be broken
out into separate methods so they can be extended such that someone can extend the processor
class and override what it means for a new version to be accepted (allowing equal versions
through? What if new is a lower not greater number?). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message