lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8077) Integer remainder modulo 1 problem in /core/src/java/org/apache/lucene/index/CheckIndex.java
Date Mon, 04 Dec 2017 13:16:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276756#comment-16276756
] 

Adrien Grand commented on LUCENE-8077:
--------------------------------------

The intention seems to be to do {{& 1}} or {{% 2}} indeed. I'll replace it with {{i %
2}} if there are no objections, tests pass.

>    Integer remainder modulo 1 problem in /core/src/java/org/apache/lucene/index/CheckIndex.java
> -----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8077
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8077
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 7.1
>            Reporter: Xiaoshan Sun
>              Labels: easyfix
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> At  /core/src/java/org/apache/lucene/index/CheckIndex.java: 2198 
> The branch condition :
> {code:java}
> (i % 1 == 0)
> {code}
> is always true. 
> Did you mean (exp & 1) or (exp % 2) instead?
> The related code is show below:
> {code:java}
> 2198:        if (i % 1 == 0) {
>           int doc2 = it2.nextDoc();
>           if (doc != doc2) {
>             throw new RuntimeException("dv iterator field=" + field + ": doc=" + doc
+ " was not found through advance() (got: " + doc2 + ")");
>           }
>           if (it2.docID() != doc) {
>             throw new RuntimeException("dv iterator field=" + field + ": doc=" + doc
+ " reports wrong doc ID (got: " + it2.docID() + ")");
>           }
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message