lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets
Date Fri, 08 Dec 2017 17:10:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283848#comment-16283848
] 

ASF GitHub Bot commented on LUCENE-8086:
----------------------------------------

Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155821440
  
    --- Diff: lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
    @@ -55,6 +55,13 @@
       private SpatialContext context;
       private PlanetModel planetModel;
     
    +  /**
    +   * Default accuracy for circles when not using the unit sphere.
    +   * It is equivalent to 10m on the surface of the earth.
    +   */
    +  private static double DEFAULT_CIRCLE_ACCURACY = 1.6e-6;
    --- End diff --
    
    should be final


> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
>                 Key: LUCENE-8086
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8086
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical
planets and therefore remove the method relate from Geo3dCircleShape. The patch will include
some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message