lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets
Date Fri, 08 Dec 2017 17:10:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283851#comment-16283851
] 

ASF GitHub Bot commented on LUCENE-8086:
----------------------------------------

Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155824604
  
    --- Diff: lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java
---
    @@ -155,16 +107,12 @@ protected Geo3dShape generateRandomShape(Point nearP) {
               ulhcPoint = lrhcPoint;
               lrhcPoint = temp;
             }
    -        final GeoBBox shape = GeoBBoxFactory.makeGeoBBox(planetModel, ulhcPoint.getY()
* DEGREES_TO_RADIANS,
    -            lrhcPoint.getY() * DEGREES_TO_RADIANS,
    -            ulhcPoint.getX() * DEGREES_TO_RADIANS,
    -            lrhcPoint.getX() * DEGREES_TO_RADIANS);
    -        return new Geo3dShape(shape, ctx);
    +        return (Geo3dShape<?>) ctx.getShapeFactory().rect(lrhcPoint, ulhcPoint);
    --- End diff --
    
    change is good but the variable names are wrong.  `rect(lowerLeft, upperRight)`


> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
>                 Key: LUCENE-8086
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8086
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical
planets and therefore remove the method relate from Geo3dCircleShape. The patch will include
some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message