lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets
Date Fri, 08 Dec 2017 17:10:00 GMT


ASF GitHub Bot commented on LUCENE-8086:

Github user dsmiley commented on a diff in the pull request:
    --- Diff: lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/
    @@ -16,29 +16,15 @@
     package org.apache.lucene.spatial.spatial4j;
    -import java.util.ArrayList;
    -import java.util.List;
    -import org.apache.lucene.spatial3d.geom.GeoPath;
    -import org.apache.lucene.spatial3d.geom.GeoPolygon;
    +import org.junit.Rule;
    +import org.junit.Test;
     import org.locationtech.spatial4j.TestLog;
     import org.locationtech.spatial4j.context.SpatialContext;
    -import org.locationtech.spatial4j.distance.DistanceUtils;
     import org.locationtech.spatial4j.shape.Circle;
     import org.locationtech.spatial4j.shape.Point;
     import org.locationtech.spatial4j.shape.RectIntersectionTestHelper;
    -import org.apache.lucene.spatial3d.geom.LatLonBounds;
    --- End diff --
    If I get this right, you've removed the Geo3D dependencies of this test.  Yet it's still
named to be Geo3d?

> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>                 Key: LUCENE-8086
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical
planets and therefore remove the method relate from Geo3dCircleShape. The patch will include
some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message