lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets
Date Fri, 08 Dec 2017 17:10:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283854#comment-16283854
] 

ASF GitHub Bot commented on LUCENE-8086:
----------------------------------------

Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155822251
  
    --- Diff: lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
    @@ -67,6 +74,25 @@ public SpatialContext getSpatialContext() {
         return context;
       }
     
    +  /**
    +   * Set the accuracy for circles.
    +   *
    +   * "Accuracy" is defined as the maximum linear distance between any point on the
    +   * surface circle and planes that describe the circle. Therefore on WSG84, since the
    +   * radius of earth is 6,371,000 meters, an accuracy of 1e-6 corresponds to 6.3 meters.
    +   * For an accuracy of 1.0 meters, the value of 1.6e-7.
    +   *
    +   * The default value is set to 10m (1.6e-6).
    +   *
    +   * Note that accuracy has no effect when the planet model is a sphere. In that case
circles
    +   * are always fully precise.
    +   *
    +   * @param circleAccuracy the provided accuracy as a linear distance.
    --- End diff --
    
    by "linear distance" do you mean decimal degrees as is used in other parts of the Spatial4j
API? If so please say "decimal degrees".  If not, perhaps it should be in that unit?


> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
>                 Key: LUCENE-8086
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8086
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical
planets and therefore remove the method relate from Geo3dCircleShape. The patch will include
some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message