lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (SOLR-3089) Make ResponseBuilder.isDistrib public
Date Tue, 09 Jan 2018 20:16:00 GMT


ASF GitHub Bot commented on SOLR-3089:

GitHub user abhidemon opened a pull request:

    test: Add test case for ResponseBuilder.isDistributed()

    This is being done for

You can merge this pull request into a Git repository by running:

    $ git pull SOLR-3089

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #301
commit 767bfbcb143a26bf325a00888c350d06a2486662
Author: abhidemon <abhishek.singh@...>
Date:   2018-01-09T20:14:34Z

    test: Add test case for ResponseBuilder.isDistributed


> Make ResponseBuilder.isDistrib public
> -------------------------------------
>                 Key: SOLR-3089
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 4.0-ALPHA
>            Reporter: Rok Rejc
>             Fix For: 4.9, 6.0
>         Attachments: Solr-3089.patch
> Hi,
> i have posted this issue on a mailing list but i didn't get any response.
> I am trying to write distributed search component (a class that extends SearchComponent).
I have checked FacetComponent and TermsComponent. If I want that search component works in
a distributed environment I have to set ResponseBuilder's isDistrib to true, like this (this
is also done in TermsComponent for example):
> 	public void prepare(ResponseBuilder rb) throws IOException {
> 		SolrParams params = rb.req.getParams();
> 		String shards = params.get(ShardParams.SHARDS);
> 		if (shards != null) {
> 			List<String> lst = StrUtils.splitSmart(shards, ",", true);
> 			rb.shards = lst.toArray(new String[lst.size()]);
> 			rb.isDistrib = true;
> 		}
> 	}
> If I have my component outside the package org.apache.solr.handler.component this doesn't
work. Is it possible to make isDistrib public (or is this the wrong procedure/behaviour/design)?
> Many thanks,
> Rok

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message