lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3218) Range faceting support for CurrencyField
Date Wed, 10 Jan 2018 04:47:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-3218:
---------------------------
    Attachment: SOLR-3218.patch

bq. There is also still one test logic flaw in testJsonRangeFacetAsSubFacet ...

Updated patch fixes that test bug, as well as adding a new test where the range facet has
a term facet (which sometimes needes refinement deepdning on the shard placement) nested underneith
it.  This new test triggers the {{refineBucket}} code path with the confusing code/comment
I asked about earlier.  Patch includes a fix to replace the odd usage of {{range.low}} with
{{range.label}} which gets the new test to pass, and doesn't seem to break anything in the
pre-existing json.facet tests.


Next up: more json.facet tests & trying to make sense of those "bits" methods in the Calc
class.


> Range faceting support for CurrencyField
> ----------------------------------------
>
>                 Key: SOLR-3218
>                 URL: https://issues.apache.org/jira/browse/SOLR-3218
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Jan H√łydahl
>            Assignee: Hoss Man
>         Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch, SOLR-3218.patch, SOLR-3218.patch,
SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch,
SOLR-3218.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for CurrencyField



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message