lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-11066) Implement a scheduled trigger
Date Sat, 27 Jan 2018 05:05:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341645#comment-16341645
] 

David Smiley edited comment on SOLR-11066 at 1/27/18 5:04 AM:
--------------------------------------------------------------

Shouldn't startTime end in a 'Z', as is standard in Solr? Why use a custom SimpleDateFormat,
which by the way is an old API? Simply parse using {{DateMathParser.parseMath(null, str).toInstant()}},
and an Instant has a toString() of the standard ISO-8601 with 'Z'

DEFAULT_GRACE_TIME_MS could be more clearly defined as: {{TimeUnit.MINUTES.toMillis(15)}}


was (Author: dsmiley):
Shouldn't startTime end in a 'Z', as is standard in Solr?  Why use a custom SimpleDateFormat,
which by the way is an old API?    Simply parse using DateMathParser.parse(str).toInstant(),
and an Instant has a toString() of the standard ISO-8601 with 'Z'

DEFAULT_GRACE_TIME_MS could be more clearly defined as: {{TimeUnit.MINUTES.toMillis(15)}}

> Implement a scheduled trigger
> -----------------------------
>
>                 Key: SOLR-11066
>                 URL: https://issues.apache.org/jira/browse/SOLR-11066
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling, SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: master (8.0), 7.3
>
>         Attachments: SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every 24 hours
starting at midnight etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message