lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11714) AddReplicaSuggester endless loop
Date Wed, 10 Jan 2018 11:29:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrzej Bialecki  updated SOLR-11714:
-------------------------------------
    Attachment: SOLR-11714.patch

The root issue for the loop was that the Policy framework can properly account for effect
of its planned changes only for a few predefined parameters (cores, diskfree, cpu, etc). However,
both SearchRateTrigger and MetricTrigger generate events that correspond to more complex cluster
state.

This patch modifies the way these triggers work, and also significantly simplifies {{ComputePlanAction}}.
Instead of relying on the Policy framework to figure out what and how many operations are
needed these triggers specify requested operations explicitly in the form of action+hints,
leaving only the target replica placement aspect to the Policy framework.

> AddReplicaSuggester endless loop
> --------------------------------
>
>                 Key: SOLR-11714
>                 URL: https://issues.apache.org/jira/browse/SOLR-11714
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>    Affects Versions: 7.2, master (8.0)
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>         Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff, SOLR-11714.patch
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and depending on
the condition either a MoveReplicaSuggester or AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master, due to an
API change (Hint.COLL_SHARD should be used instead of Hint.COLL). However, after fixing that
bug {{ComputePlanAction}} goes into an endless loop because the suggester endlessly keeps
creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the unit test
to illustrate this failure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message