lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amrit Sarkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11718) Deprecate CDCR Buffer APIs
Date Tue, 16 Jan 2018 00:01:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326644#comment-16326644
] 

Amrit Sarkar commented on SOLR-11718:
-------------------------------------

[~varunthacker],

bq. We should remove the checkpoint asserts that are currently commented out in CdcrRequestHandlerTest
right?
Right. We decided to remove the commneted lines at the time of commit patch.
bq. How about this in the deprecation message in the docs "ENABLEBUFFER API has been deprecated.
Solr now uses replication to catch up with the source if the target is down for an extended
period of time."  and the same message for DISABLEBUFFER as well
Certainly more human. But warning for enabling Buffer should be posted too right? maybe a
common note and not in both DISABLE and ENABLE buffer apis.
bq. We should add a test which explicitly enabled buffering and does a few sanity tests. This
feature still needs to be tested till it's removed
Sure. We can have old test cases in place (few of them) for buffer enabled.

I will write the updated patch for above three if agreed upon.

> Deprecate CDCR Buffer APIs
> --------------------------
>
>                 Key: SOLR-11718
>                 URL: https://issues.apache.org/jira/browse/SOLR-11718
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: CDCR
>    Affects Versions: 7.1
>            Reporter: Amrit Sarkar
>            Priority: Major
>             Fix For: master (8.0), 7.3
>
>         Attachments: SOLR-11718-v3.patch, SOLR-11718.patch, SOLR-11718.patch
>
>
> Kindly see the discussion on SOLR-11652.
> Today, if we see the current CDCR documentation page, buffering is "disabled" by default
in both source and target. We don't see any purpose served by Cdcr buffering and it is quite
an overhead considering it can take a lot heap space (tlogs ptr) and forever retention of
tlogs on the disk when enabled. Also today, even if we disable buffer from API on source ,
considering it was enabled at startup, tlogs are never purged on leader node of shards of
source, refer jira: SOLR-11652



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message