lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-11804) Test RankQuery in distributed mode
Date Tue, 23 Jan 2018 04:22:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335372#comment-16335372
] 

Tomás Fernández Löbbe commented on SOLR-11804:
----------------------------------------------

Thanks [~diegoceccarelli]. The patch looks good, although {{q=all}} only returns 2 docs, maybe
the test can be improved by having a better query (that returns at least the re-rank amount
of docs?). In line with that, even if in many cases (specially in this test) we only validate
distributed vs non-distributed, I'd prefer if you checked something of the response, at least
to make sure docs are coming back, maybe like:
{code:java}
    QueryResponse response = query("q",facetQuery, "rows",100, "facet","true",
          "facet.range",tlong,
          "facet.range.start",200,
          "facet.range.gap",100,
          "facet.range.end",900,
          "facet.range.other","all");
    assertEquals(tlong, response.getFacetRanges().get(0).getName());
    assertEquals(new Integer(6), response.getFacetRanges().get(0).getBefore());
    assertEquals(new Integer(5), response.getFacetRanges().get(0).getBetween());
    assertEquals(new Integer(2), response.getFacetRanges().get(0).getAfter());{code}

> Test RankQuery in distributed mode
> ----------------------------------
>
>                 Key: SOLR-11804
>                 URL: https://issues.apache.org/jira/browse/SOLR-11804
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Diego Ceccarelli
>            Priority: Minor
>
> Currently {{RankQuery}} is not tested in distributed mode. I added a few tests in `TestDistributedSearch`
to check that it works properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message