lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8117) advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer
Date Thu, 04 Jan 2018 19:11:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311874#comment-16311874
] 

Adrien Grand commented on LUCENE-8117:
--------------------------------------

+1 patch looks good, great catch!

I see we had some tests in CheckIndex for advanceExact, but they only check whether the return
value is expected, not whether we then produce the expected values. Probably something we
should look into beefing up, I'm now wondering some other codecs could have similar issues.

> advanceExact does not work on sorted numeric dvs with Lucene54DocValuesProducer 
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-8117
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8117
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 7.2
>            Reporter: Jim Ferenczi
>         Attachments: LUCENE-8117.patch
>
>
> DocValues are iterators now so old doc values (produced with Lucene54DocValues) also
implements advance and advanceExact. Though sorted numerics produced by Lucene54DocValues
are not working as expected when advanceExact is used. 
> In such case, the docValueCount is as expected but the values returned by the iterator
for the document are invalid. This is due to a bug in the implementation of advanceExact in
the producer that does not set the offset of the current doc when the function is used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message