lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8149) NRTCachingDirectory does not need to preemptively delete segment files and generate exceptions
Date Mon, 05 Feb 2018 19:25:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352805#comment-16352805
] 

ASF subversion and git services commented on LUCENE-8149:
---------------------------------------------------------

Commit 4bd49726c1416a6146c9bbb86fdf4d7c2adc2b1c in lucene-solr's branch refs/heads/master
from Erick Erickson
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4bd4972 ]

LUCENE-8149: NRTCachingDirectory does not need to preemptively delete segment files and generate
exceptions


> NRTCachingDirectory does not need to preemptively delete segment files and generate exceptions
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8149
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8149
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: LUCENE-8149.patch
>
>
> Moving over here from SOLR-11892. After getting through my confusion I've found the following:
NRTCachingDirectory.createOutput tries to delete segment files before creating them. We should
at least add a bit of commentary as to what the pre-emptive delete is there for since on the
surface it's not obvious.
> try {
>   in.deleteFile(name);
> {{ } catch (IOException ioe) {}}
>   // This is fine: file may not exist
> {{ }}}
> If I change to using MMapDirectory or NIOFSDirectory these exceptions are not thrown.
What's special about NRTCachingDirectory that it needs this when two of the possible underlying
FS implementations apparently do not? Or is this necessary for, say, Windows or file systems
than the two I tried? Or is it some interaction between the RAM based segments and segments
on disk?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message