lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8338) Ensure number returned for PendingDeletes are well defined
Date Thu, 31 May 2018 07:20:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496206#comment-16496206
] 

ASF subversion and git services commented on LUCENE-8338:
---------------------------------------------------------

Commit 76263087b5828446fa3afd05743a8383b75893fb in lucene-solr's branch refs/heads/master
from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7626308 ]

LUCENE-8338: Ensure number returned for PendingDeletes are well defined

Today a call to PendingDeletes#numPendingDeletes might return 0
if the deletes are written to disk. This doesn't mean these values are committed
or refreshed in the latest reader. Some places in IW use these numbers to make
decisions if there has been deletes added since last time checked (BufferedUpdateStream)
which can cause wrong (while not fatal) decision ie. to kick of new merges.

Now this API is made protected and not visible outside of PendingDeletes to prevent
any kind of confusion. The APIs now allow to get absolute numbers of getDelCount and numDocs
which have the same name and semantics as their relatives on IndexReader/Writer
and SegmentCommitInfo.


> Ensure number returned for PendingDeletes are well defined
> ----------------------------------------------------------
>
>                 Key: LUCENE-8338
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8338
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8338.patch, LUCENE-8338.patch
>
>
>  Today a call to PendingDeletes#numPendingDeletes might return 0
>     if the deletes are written to disk. This doesn't mean these values are committed
>     or refreshed in the latest reader. Some places in IW use these numbers to make
>     decisions if there has been deletes added since last time checked (BufferedUpdateStream)
>     which can cause wrong (while not fatal) decision ie. to kick of new merges.
>     
>     Now this API is made protected and not visible outside of PendingDeletes to prevent
>     any kind of confusion. The APIs now allow to get absolute numbers of getDelCount
and numDocs
>     which have the same name and semantics as their relatives on IndexReader/Writer
>     and SegmentCommitInfo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message