lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12008) Settle a location for the "correct" log4j2.xml file.
Date Sat, 07 Jul 2018 15:28:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535800#comment-16535800
] 

Erick Erickson commented on SOLR-12008:
---------------------------------------

Hmmm, that's...odd. I have some suspicions that I'll check out, may need to ask you to run
with some debugging code if you have the bandwidth.

There are a number of places where I had to change to {{%SOME_VAR%\cloud-scripts\log4j2.xml
}} to {{ %SOME_OTHER_VAR%/../../resources/log4j2-console.xml }}, I suspect that some  other
code is manipulating the path inappropriately.

Digging anyway...


> Settle a location for the "correct" log4j2.xml file.
> ----------------------------------------------------
>
>                 Key: SOLR-12008
>                 URL: https://issues.apache.org/jira/browse/SOLR-12008
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: logging
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12008.patch, SOLR-12008.patch, SOLR-12008.patch
>
>
> As part of SOLR-11934 I started looking at log4j.properties files. Waaay back in 2015,
the %C in "/solr/server/resources/log4j.properties" was changed to use %c, but the file in
"solr/example/resources/log4j.properties" was not changed. That got me to looking around and
there are a bunch of log4j.properties files:
> ./solr/core/src/test-files/log4j.properties
> ./solr/example/resources/log4j.properties
> ./solr/solrj/src/test-files/log4j.properties
> ./solr/server/resources/log4j.properties
> ./solr/server/scripts/cloud-scripts/log4j.properties
> ./solr/contrib/dataimporthandler/src/test-files/log4j.properties
> ./solr/contrib/clustering/src/test-files/log4j.properties
> ./solr/contrib/ltr/src/test-files/log4j.properties
> ./solr/test-framework/src/test-files/log4j.properties
> Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I propose
the logging configuration files get consolidated. The question is "how far"? 
> I at least want to get rid of the one in solr/example, users should use the one in server/resources.
Having to maintain these two separately is asking for trouble.
> [~markrmiller@gmail.com] Do you have any wisdom on the properties file in server/scripts/cloud-scripts?
> Anyone else who has a clue about why the other properties files were created, especially
the ones in contrib?
> And what about all the ones in various test-files directories? People didn't create them
for no reason, and I don't want to rediscover that it's a real pain to try to re-use the one
in server/resources for instance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message